deps: update V8 to 7.7 #28918

targos · 2019-08-01T13:24:49Z

ETA: Sept 10th, 2019

nodejs-github-bot · 2019-08-01T13:26:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24812/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2440/

targos · 2019-08-01T16:50:54Z

There are a few postmortem-related issues:

15:35:12 dtrace: failed to compile script src/v8ustack.d: line 414: failed to resolve V8DBG_CLASS_CONSSTRING__FIRST__STRING: Unknown variable name

15:55:33 not ok 1 v8-updates/test-postmortem-metadata
15:55:33   ---
15:55:33   duration_ms: 0.262
15:55:33   severity: fail
15:55:33   exitcode: 1
15:55:33   stack: |-
15:55:33     assert.js:89
15:55:33       throw new AssertionError(obj);
15:55:33       ^
15:55:33     
15:55:33     AssertionError [ERR_ASSERTION]: Missing constants: v8dbg_class_ConsString__first__String,v8dbg_class_ConsString__second__String,v8dbg_class_SlicedString__offset__SMI,v8dbg_class_ThinString__actual__String

/cc @nodejs/platform-smartos

targos · 2019-08-01T16:52:25Z

V8 CI failed on all IBM platforms with this error:

15:27:46 ERROR at //BUILD.gn:1032:14: Unknown function.
15:27:46     filetq = string_replace(file, ".tq", "-tq-csa")
15:27:46              ^-------------

Maybe GN needs an update?

Example: https://ci.nodejs.org/job/node-test-commit-v8-linux/2440/nodes=centos7-ppcle,v8test=v8test/console

cjihrig · 2019-08-01T16:53:01Z

@targos I'll fix those up here and update the existing V8 CR (trying to avoid working with Gerrit as much as possible).

targos · 2019-08-02T07:52:58Z

/cc @nodejs/platform-ppc for #28918 (comment)

miladfarca · 2019-08-02T13:04:28Z

@targos gn needs to be updated, latest gn runs fine on ppc and the above remote ref, tested on ubuntu1404-ppc64_le-2

targos · 2019-08-02T13:41:40Z

@miladfarca Thanks, I opened nodejs/build#1881 to ask the build WG to update gn.

cjihrig · 2019-08-07T17:29:28Z

@targos please cherry-pick cjihrig@d9326fa, cjihrig@c9c0757, and cjihrig@46ac4d3 to fix the postmortem and SmartOS failures.

targos · 2019-08-13T12:32:24Z

@cjihrig Thanks, I included your commits.

nodejs-github-bot · 2019-08-13T12:33:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24961/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2462/

nodejs-github-bot · 2019-08-13T21:21:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24972/

devsnek · 2019-08-13T22:23:11Z

This change ships https://github.com/tc39/proposal-unified-intl-numberformat

nodejs-github-bot · 2019-08-16T10:01:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25026/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2466/

nodejs-github-bot · 2019-08-16T13:44:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25027/

targos · 2019-08-16T16:11:35Z

/cc @nodejs/v8-update @nodejs/tsc

I'd like to land this early. If we do that, it gives us time to try and include it in v12.x.
V8 7.7 was already branched upstream and should only get bugfixes until its stable release.

bnoordhuis

LGTM, nice job!

We've accreted quite a few patches on top of V8 lately. Are there plans to upstream them?

I suppose in some cases we'll have to carry them forward because the V8 team probably isn't interested in supporting older compilers.

bnoordhuis · 2019-08-16T16:25:07Z

common.gypi

@@ -39,7 +39,7 @@

    # Reset this number to 0 on major V8 upgrades.
    # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.6',
+    'v8_embedder_string': '-node.7',


There's a typo in the commit log (s/in all platforms/on all platforms/) and I don't see that -Wbraced-scalar-init it mentions anywhere.

Thanks, I'll fix that

targos · 2019-08-16T16:40:32Z

We've accreted quite a few patches on top of V8 lately. Are there plans to upstream them?

I can try to upstream some of the changes but I don't understand all of them enough to explain the V8 team why they are necessary.

Trott · 2019-08-17T03:57:57Z

/cc @nodejs/v8-update @nodejs/tsc

I'd like to land this early. If we do that, it gives us time to try and include it in v12.x.
V8 7.7 was already branched upstream and should only get bugfixes until its stable release.

I'm +1 to "land this when @targos thinks it should be landed".

Trott

Rubber stamp LGTM

The following metadata has changed: - v8dbg_class_ConsString__first__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__first_offset__int - Refs: v8/v8@14274bb - v8dbg_class_ConsString__second__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__second_offset__int - Refs: v8/v8@14274bb - v8dbg_class_SlicedString__offset__SMI - Class is now generated via torque. - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int - Refs: v8/v8@14274bb - v8dbg_class_ThinString__actual__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int - Refs: v8/v8@14274bb PR-URL: nodejs#28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Update postmortem metadata constants for V8 7.7 in Node.js. Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com> Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

The following metadata has changed: - v8dbg_class_ConsString__first__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__first_offset__int - Refs: v8/v8@14274bb - v8dbg_class_ConsString__second__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__second_offset__int - Refs: v8/v8@14274bb - v8dbg_class_SlicedString__offset__SMI - Class is now generated via torque. - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int - Refs: v8/v8@14274bb - v8dbg_class_ThinString__actual__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int - Refs: v8/v8@14274bb Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Backport-PR-URL: #29241 PR-URL: #28918 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Notable changes: * crypto: * Add `oaepLabel` option #29489 * deps: * Update V8 to 7.7.299.11 #28918 * More efficient memory handling * Stack trace serialization got faster * The `Intl.NumberFormat` API gained new functionality * For more information: https://v8.dev/blog/v8-release-77 * events: * Add support for `EventTarget` in `once` #29498 * fs: * Expose memory file mapping flag `UV_FS_O_FILEMAP` #29260 * inspector: * New API - `Session.connectToMainThread` #28870 * process: * Initial SourceMap support via `env.NODE_V8_COVERAGE` #28960 * stream: * Make `_write()` optional when `_writev()` is implemented #29639 * tls: * Add option to override signature algorithms #29598 * util: * Add `encodeInto` to `TextEncoder` #29524 * worker: * The `worker_thread` module is now stable #29512

Notable changes: * crypto: * Add `oaepLabel` option #29489 * deps: * Update V8 to 7.7.299.11 #28918 * More efficient memory handling * Stack trace serialization got faster * The `Intl.NumberFormat` API gained new functionality * For more information: https://v8.dev/blog/v8-release-77 * events: * Add support for `EventTarget` in `once` #29498 * fs: * Expose memory file mapping flag `UV_FS_O_FILEMAP` #29260 * inspector: * New API - `Session.connectToMainThread` #28870 * process: * Initial SourceMap support via `env.NODE_V8_COVERAGE` #28960 * stream: * Make `_write()` optional when `_writev()` is implemented #29639 * tls: * Add option to override signature algorithms #29598 * util: * Add `encodeInto` to `TextEncoder` #29524 * worker: * The `worker_thread` module is now stable #29512 PR-URL: #29695

Builds from the source tarball were broken by the recent V8 upate to 7.7 as a file needed to build torque wasn't included in the source tarball as it resides in deps/v8/test. PR-URL: #29712 Fixes: #29709 Refs: #28918 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

Notable changes: - **assert**: - do not repeat .throws() code (Ruben Bridgewater) [#28263](#28263) - wrap validation function errors (Ruben Bridgewater) [#28263](#28263) - fix generatedMessage property (Ruben Bridgewater) [#28263](#28263) - improve class instance errors (Ruben Bridgewater) [#28263](#28263) - **benchmark**: - use test/common/tmpdir consistently (João Reis) [#28858](#28858) - **build**: - make full-icu the default for releases (Richard Lau) [#29887](#29887) - update minimum Xcode version for macOS (Michael Dawson) [#29622](#29622) - **child_process**: - runtime deprecate \_channel (cjihrig) [#27949](#27949) - simplify spawn argument parsing (cjihrig) [#27854](#27854) - **console**: - display timeEnd with suitable time unit (Xavier Stouder) [#29251](#29251) - **deps**: - patch V8 to 7.8.279.14 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.12 (Myles Borins) [#29694](#29694) - patch V8 to 7.8.279.10 (Myles Borins) [#29694](#29694) - update V8's postmortem script (cjihrig) [#29694](#29694) - V8: cherry-pick 716875d (Myles Borins) [#29694](#29694) - update V8 to 7.8.279.9 (Myles Borins) [#29694](#29694) - V8: cherry-pick b33af60 (Michaël Zasso) [#28016](#28016) - update V8 to 7.6.303.28 (Michaël Zasso) [#28016](#28016) - **domain**: - error handler runs outside of its domain (Julien Gilli) [#26211](#26211) - **fs**: - make FSWatcher.start private (Lucas Holmquist) [#29905](#29905) - add runtime deprecate for file stream open() (Robert Nagy) [#29061](#29061) - allow int64 offset in fs.write/writeSync/fd.write (Zach Bjornson) [#26572](#26572) - use IsSafeJsInt instead of IsNumber for ftruncate (Zach Bjornson) [#26572](#26572) - allow int64 offset in fs.read/readSync/fd.read (Zach Bjornson) [#26572](#26572) - close file descriptor of promisified truncate (João Reis) [#28858](#28858) - **http**: - do not emit end after aborted (Robert Nagy) [#27984](#27984) - don't emit 'data' after 'error' (Robert Nagy) [#28711](#28711) - remove legacy parser (Anna Henningsen) [#29589](#29589) - throw if 'host' agent header is not a string value (Giorgos Ntemiris) [#29568](#29568) - replace superfluous connection property with getter/setter (Robert Nagy) [#29015](#29015) - fix test where aborted should not be emitted (Robert Nagy) [#20077](#20077) - remove default 'timeout' listener on upgrade (Luigi Pinca) [#26030](#26030) - **http, http2**: - remove default server timeout (Ali Ijaz Sheikh) [#27558](#27558) - **http2**: - remove security revert flags (Anna Henningsen) [#29141](#29141) - remove callback-based padding (Anna Henningsen) [#29144](#29144) - **lib**: - rename validateInteger to validateSafeInteger (Zach Bjornson) [#26572](#26572) - correct error.errno to always be numeric (Joyee Cheung) [#28140](#28140) - no need to strip BOM or shebang for scripts (Refael Ackermann) [#27375](#27375) - rework logic of stripping BOM+Shebang from commonjs (Gus Caplan) [#27768](#27768) - **module**: - runtime deprecate createRequireFromPath() (cjihrig) [#27951](#27951) - **readline**: - error on falsy values for callback (Sam Roberts) [#28109](#28109) - **repl**: - close file descriptor of history file (João Reis) [#28858](#28858) - **src**: - bring 425 status code name into accordance with RFC 8470 (Sergei Osipov) [#29880](#29880) - update NODE\_MODULE\_VERSION to 79 (Myles Borins) [#29694](#29694) - update NODE\_MODULE\_VERSION to 78 (Michaël Zasso) [#28918](#28918) - add error codes to errors thrown in C++ (Yaniv Friedensohn) [#27700](#27700) - use non-deprecated overload of V8::SetFlagsFromString (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 77 (Michaël Zasso) [#28016](#28016) - update NODE\_MODULE\_VERSION to 74 (Refael Ackermann) [#27375](#27375) - make process.env.TZ setter clear tz cache (Ben Noordhuis) [#20026](#20026) - enable V8's WASM trap handlers (Gus Caplan) [#27246](#27246) - **stream**: - throw unhandled error for readable with autoDestroy (Robert Nagy) [#29806](#29806) - always invoke callback before emitting error (Robert Nagy) [#29293](#29293) - invoke callback before emitting error always (Robert Nagy) [#29293](#29293) - do not flush destroyed writable (Robert Nagy) [#29028](#29028) - don't emit finish on error (Robert Nagy) [#28979](#28979) - disallow stream methods on finished stream (Robert Nagy) [#28687](#28687) - do not emit after 'error' (Robert Nagy) [#28708](#28708) - fix destroy() behavior (Robert Nagy) [#29058](#29058) - simplify `.pipe()` and `.unpipe()` in Readable (Weijia Wang) [#28583](#28583) - **tools**: - patch V8 to run on older XCode versions (Ujjwal Sharma) [#29694](#29694) - update V8 gypfiles (Michaël Zasso) [#29694](#29694) - support full-icu by default (Steven R. Loomis) [#29522](#29522) - **util**: validate formatWithOptions inspectOptions (Ruben Bridgewater) [#29824](#29824) PR-URL: #29504

liudonghua123 · 2019-12-13T01:34:19Z

Did the update cause the issue on facebook/metro#468?

targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. blocked PRs that are blocked by other issues or PRs. labels Aug 1, 2019

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 1, 2019

cjihrig mentioned this pull request Aug 7, 2019

Upcoming metadata changes in V8 7.7 nodejs/llnode#287

Closed

mikehardy mentioned this pull request Aug 9, 2019

Node >= 12.5 OSX memory spike #28558

Closed

targos force-pushed the v8-7.7 branch from 56c4f8e to 45837a1 Compare August 13, 2019 12:32

targos force-pushed the v8-7.7 branch from 45837a1 to 28db63b Compare August 16, 2019 10:01

cjihrig approved these changes Aug 16, 2019

View reviewed changes

bnoordhuis approved these changes Aug 16, 2019

View reviewed changes

targos removed the blocked PRs that are blocked by other issues or PRs. label Aug 16, 2019

gengjiawen approved these changes Aug 17, 2019

View reviewed changes

Trott approved these changes Aug 17, 2019

View reviewed changes

targos added the backported-to-v12.x label Sep 19, 2019

BridgeAR mentioned this pull request Sep 24, 2019

v12.11.0 proposal #29695

Merged

This was referenced Sep 26, 2019

build: include deps/v8/test/torque in source tarball #29712

Closed

test-torque.tq failing source tarball builds for v12.11.0 (V8 7.7) #29709

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 7.7 #28918

deps: update V8 to 7.7 #28918

targos commented Aug 1, 2019

nodejs-github-bot commented Aug 1, 2019 •

edited by targos

Loading

targos commented Aug 1, 2019

targos commented Aug 1, 2019 •

edited

Loading

cjihrig commented Aug 1, 2019 •

edited

Loading

targos commented Aug 2, 2019

miladfarca commented Aug 2, 2019

targos commented Aug 2, 2019

cjihrig commented Aug 7, 2019

targos commented Aug 13, 2019

nodejs-github-bot commented Aug 13, 2019 •

edited by targos

Loading

nodejs-github-bot commented Aug 13, 2019

devsnek commented Aug 13, 2019

nodejs-github-bot commented Aug 16, 2019 •

edited by targos

Loading

nodejs-github-bot commented Aug 16, 2019

targos commented Aug 16, 2019 •

edited

Loading

bnoordhuis left a comment

bnoordhuis Aug 16, 2019

targos Aug 16, 2019

targos commented Aug 16, 2019

Trott commented Aug 17, 2019

Trott left a comment

liudonghua123 commented Dec 13, 2019

deps: update V8 to 7.7 #28918

deps: update V8 to 7.7 #28918

Conversation

targos commented Aug 1, 2019

nodejs-github-bot commented Aug 1, 2019 • edited by targos Loading

targos commented Aug 1, 2019

targos commented Aug 1, 2019 • edited Loading

cjihrig commented Aug 1, 2019 • edited Loading

targos commented Aug 2, 2019

miladfarca commented Aug 2, 2019

targos commented Aug 2, 2019

cjihrig commented Aug 7, 2019

targos commented Aug 13, 2019

nodejs-github-bot commented Aug 13, 2019 • edited by targos Loading

nodejs-github-bot commented Aug 13, 2019

devsnek commented Aug 13, 2019

nodejs-github-bot commented Aug 16, 2019 • edited by targos Loading

nodejs-github-bot commented Aug 16, 2019

targos commented Aug 16, 2019 • edited Loading

bnoordhuis left a comment

Choose a reason for hiding this comment

bnoordhuis Aug 16, 2019

Choose a reason for hiding this comment

targos Aug 16, 2019

Choose a reason for hiding this comment

targos commented Aug 16, 2019

Trott commented Aug 17, 2019

Trott left a comment

Choose a reason for hiding this comment

liudonghua123 commented Dec 13, 2019

nodejs-github-bot commented Aug 1, 2019 •

edited by targos

Loading

targos commented Aug 1, 2019 •

edited

Loading

cjihrig commented Aug 1, 2019 •

edited

Loading

nodejs-github-bot commented Aug 13, 2019 •

edited by targos

Loading

nodejs-github-bot commented Aug 16, 2019 •

edited by targos

Loading

targos commented Aug 16, 2019 •

edited

Loading